diff options
| author | Vladimir Oltean <vladimir.oltean@nxp.com> | 2022-03-02 21:14:08 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2022-03-03 14:15:31 +0000 |
| commit | 35aae5ab91219f295b298ea922308d33c06470b3 (patch) | |
| tree | e215dfc70ad137d820ff3f105c0a3f8893138845 /net/dsa/port.c | |
| parent | 43113ff73453c231af2c8e700cb4ff8bca97cff6 (diff) | |
net: dsa: remove workarounds for changing master promisc/allmulti only while up
Lennert Buytenhek explains in commit df02c6ff2e39 ("dsa: fix master
interface allmulti/promisc handling"), dated Nov 2008, that changing the
promiscuity of interfaces that are down (here the master) is broken.
This fact regarding promisc/allmulti has changed since commit
b6c40d68ff64 ("net: only invoke dev->change_rx_flags when device is UP")
by Vlad Yasevich, dated Nov 2013.
Therefore, DSA now has unnecessary complexity to handle master state
transitions from down to up. In fact, syncing the unicast and multicast
addresses can happen completely asynchronously to the administrative
state changes.
This change reduces that complexity by effectively fully reverting
commit df02c6ff2e39 ("dsa: fix master interface allmulti/promisc
handling").
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/dsa/port.c')
0 files changed, 0 insertions, 0 deletions