diff options
| author | Chuck Lever <chuck.lever@oracle.com> | 2023-09-21 09:07:40 -0400 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2023-10-02 12:34:21 -0700 |
| commit | a6b07a51b161ba1ad3d81919955fe77b697f9d48 (patch) | |
| tree | 69b5a338fb249d8f73322b1824c2e335da11af8b /net/handshake/netlink.c | |
| parent | af54c197a90b804b57eb7ae4256aaeb5c46216c5 (diff) | |
handshake: Fix sign of socket file descriptor fields
Socket file descriptors are signed integers. Use nla_get/put_s32 for
those to avoid implicit signed conversion in the netlink protocol.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://lore.kernel.org/r/169530165057.8905.8650469415145814828.stgit@oracle-102.nfsv4bat.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'net/handshake/netlink.c')
| -rw-r--r-- | net/handshake/netlink.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/handshake/netlink.c b/net/handshake/netlink.c index d0bc1dd8e65a..64a0046dd611 100644 --- a/net/handshake/netlink.c +++ b/net/handshake/netlink.c @@ -163,7 +163,7 @@ int handshake_nl_done_doit(struct sk_buff *skb, struct genl_info *info) if (GENL_REQ_ATTR_CHECK(info, HANDSHAKE_A_DONE_SOCKFD)) return -EINVAL; - fd = nla_get_u32(info->attrs[HANDSHAKE_A_DONE_SOCKFD]); + fd = nla_get_s32(info->attrs[HANDSHAKE_A_DONE_SOCKFD]); sock = sockfd_lookup(fd, &err); if (!sock) |