diff options
author | Gustavo A. R. Silva <gustavo@embeddedor.com> | 2018-12-10 12:41:24 -0600 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2018-12-10 12:10:38 -0800 |
commit | 5648451e30a0d13d11796574919a359025d52cce (patch) | |
tree | 277562e851c9842f78cd32c99d1a25fd91fcc7f6 /net/ipv4/ipcomp.c | |
parent | 4a2eb0c37b4759416996fbb4c45b932500cf06d3 (diff) |
ipv4: Fix potential Spectre v1 vulnerability
vr.vifi is indirectly controlled by user-space, hence leading to
a potential exploitation of the Spectre variant 1 vulnerability.
This issue was detected with the help of Smatch:
net/ipv4/ipmr.c:1616 ipmr_ioctl() warn: potential spectre issue 'mrt->vif_table' [r] (local cap)
net/ipv4/ipmr.c:1690 ipmr_compat_ioctl() warn: potential spectre issue 'mrt->vif_table' [r] (local cap)
Fix this by sanitizing vr.vifi before using it to index mrt->vif_table'
Notice that given that speculation windows are large, the policy is
to kill the speculation on the first load and not worry if it can be
completed with a dependent load/store [1].
[1] https://marc.info/?l=linux-kernel&m=152449131114778&w=2
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/ipcomp.c')
0 files changed, 0 insertions, 0 deletions