diff options
| author | Florian Westphal <fw@strlen.de> | 2022-09-06 17:20:35 +0200 |
|---|---|---|
| committer | Florian Westphal <fw@strlen.de> | 2022-09-07 16:46:04 +0200 |
| commit | c92c27171040554cfda7a3fc925e9dbcb5b4a698 (patch) | |
| tree | 59d7fc3e6dbecbee86cb99add3454a1f999f5047 /net/netfilter/nf_nat_sip.c | |
| parent | 8556bceb9c409946eebd2303d2f19e87844195ae (diff) | |
netfilter: nat: move repetitive nat port reserve loop to a helper
Almost all nat helpers reserve an expecation port the same way:
Try the port inidcated by the peer, then move to next port if that
port is already in use.
We can squash this into a helper.
Suggested-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Florian Westphal <fw@strlen.de>
Diffstat (limited to 'net/netfilter/nf_nat_sip.c')
| -rw-r--r-- | net/netfilter/nf_nat_sip.c | 14 |
1 files changed, 1 insertions, 13 deletions
diff --git a/net/netfilter/nf_nat_sip.c b/net/netfilter/nf_nat_sip.c index f0a735e86851..cf4aeb299bde 100644 --- a/net/netfilter/nf_nat_sip.c +++ b/net/netfilter/nf_nat_sip.c @@ -410,19 +410,7 @@ static unsigned int nf_nat_sip_expect(struct sk_buff *skb, unsigned int protoff, exp->dir = !dir; exp->expectfn = nf_nat_sip_expected; - for (; port != 0; port++) { - int ret; - - exp->tuple.dst.u.udp.port = htons(port); - ret = nf_ct_expect_related(exp, NF_CT_EXP_F_SKIP_MASTER); - if (ret == 0) - break; - else if (ret != -EBUSY) { - port = 0; - break; - } - } - + port = nf_nat_exp_find_port(exp, port); if (port == 0) { nf_ct_helper_log(skb, ct, "all ports in use for SIP"); return NF_DROP; |