summaryrefslogtreecommitdiff
path: root/net/strparser
diff options
context:
space:
mode:
authorVakul Garg <vakul.garg@nxp.com>2018-06-21 03:29:49 +0530
committerDavid S. Miller <davem@davemloft.net>2018-06-21 09:54:05 +0900
commit456488cd952c23d451b0bdc5b5226b0707db80f7 (patch)
tree99832c64a319d35a3b9475539654f1e1df03464b /net/strparser
parent73f9c33beb9e85850a11a1597b35a13650352509 (diff)
strparser: Don't schedule in workqueue in paused state
In function strp_data_ready(), it is useless to call queue_work if the state of strparser is already paused. The state checking should be done before calling queue_work. The change reduces the context switches and improves the ktls-rx throughput by approx 20% (measured on cortex-a53 based platform). Signed-off-by: Vakul Garg <vakul.garg@nxp.com> Acked-by: Dave Watson <davejwatson@fb.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/strparser')
-rw-r--r--net/strparser/strparser.c5
1 files changed, 1 insertions, 4 deletions
diff --git a/net/strparser/strparser.c b/net/strparser/strparser.c
index 1a9695183599..373836615c57 100644
--- a/net/strparser/strparser.c
+++ b/net/strparser/strparser.c
@@ -392,7 +392,7 @@ static int strp_read_sock(struct strparser *strp)
/* Lower sock lock held */
void strp_data_ready(struct strparser *strp)
{
- if (unlikely(strp->stopped))
+ if (unlikely(strp->stopped) || strp->paused)
return;
/* This check is needed to synchronize with do_strp_work.
@@ -407,9 +407,6 @@ void strp_data_ready(struct strparser *strp)
return;
}
- if (strp->paused)
- return;
-
if (strp->need_bytes) {
if (strp_peek_len(strp) < strp->need_bytes)
return;