diff options
| author | Takashi Iwai <tiwai@suse.de> | 2021-06-08 16:05:30 +0200 |
|---|---|---|
| committer | Takashi Iwai <tiwai@suse.de> | 2021-06-09 17:30:26 +0200 |
| commit | f9a6bb841f737015aface3ba4ac845e66542850e (patch) | |
| tree | 4ea091922c864e6dbc5b75c4117357f293f1ccf0 /sound/core/seq/oss/seq_oss_rw.c | |
| parent | 51c816fdd17c63352b04e67c6c5ccaa3417f39aa (diff) | |
ALSA: seq: Fix assignment in if condition
There are lots of places doing assignments in if condition in ALSA
sequencer core, which is a bad coding style that may confuse readers
and occasionally lead to bugs.
This patch is merely for coding-style fixes, no functional changes.
Link: https://lore.kernel.org/r/20210608140540.17885-57-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/core/seq/oss/seq_oss_rw.c')
| -rw-r--r-- | sound/core/seq/oss/seq_oss_rw.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/sound/core/seq/oss/seq_oss_rw.c b/sound/core/seq/oss/seq_oss_rw.c index 537d5f423e20..8a142fd54a19 100644 --- a/sound/core/seq/oss/seq_oss_rw.c +++ b/sound/core/seq/oss/seq_oss_rw.c @@ -132,7 +132,8 @@ snd_seq_oss_write(struct seq_oss_devinfo *dp, const char __user *buf, int count, } /* insert queue */ - if ((err = insert_queue(dp, &rec, opt)) < 0) + err = insert_queue(dp, &rec, opt); + if (err < 0) break; result += ev_size; |