summaryrefslogtreecommitdiff
path: root/sound/firewire
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2015-10-15 21:17:11 +0300
committerTakashi Iwai <tiwai@suse.de>2015-10-17 12:06:28 +0200
commit724097059a8e5df1aa162d153b8f90b0ffbb82dc (patch)
tree6cef9c43b73c61a3d182db8df2880a812f1abf85 /sound/firewire
parent69ec98d7e5661a1c98ec51c26d6e91af3bbe0e72 (diff)
ALSA: firewire-tascam: off by one in handle_midi_tx()
My static checker complains because tscm->spec->midi_capture_ports is either 2 or 4 but the tscm->tx_midi_substreams[] array has 4 elements so this is possibly off by one. I have looked at the code and I think it should be >= instead of > as well. Fixes: 107cc0129a68 ('ALSA: firewire-tascam: add support for incoming MIDI messages by asynchronous transaction') Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/firewire')
-rw-r--r--sound/firewire/tascam/tascam-transaction.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/firewire/tascam/tascam-transaction.c b/sound/firewire/tascam/tascam-transaction.c
index 45c3ce3d6020..d4f64ae182e7 100644
--- a/sound/firewire/tascam/tascam-transaction.c
+++ b/sound/firewire/tascam/tascam-transaction.c
@@ -158,7 +158,7 @@ static void handle_midi_tx(struct fw_card *card, struct fw_request *request,
port = b[0] >> 4;
/* TODO: support virtual MIDI ports. */
- if (port > tscm->spec->midi_capture_ports)
+ if (port >= tscm->spec->midi_capture_ports)
goto end;
/* Assume the message length. */