diff options
| author | Cezary Rojewski <cezary.rojewski@intel.com> | 2025-01-09 13:22:06 +0100 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2025-01-09 12:14:18 +0000 |
| commit | cf4d74256fe103ece7b2647550e6c063048e5682 (patch) | |
| tree | 09ce273332ab2332d2dac31422866988bf6e49b9 /sound/soc/intel/avs/apl.c | |
| parent | dbda5c35b88794f6e5efe1b5b20044b0b3a340d4 (diff) | |
ASoC: Intel: avs: Fix theoretical infinite loop
While 'stack_dump_size' is a u32 bitfield of 16 bits, u32 has a bigger
upper bound than the type u16 of loop counter 'offset' what in theory
may lead to infinite loop condition.
Found out by Coverity static analyzer.
Fixes: c8c960c10971 ("ASoC: Intel: avs: APL-based platforms support")
Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
Link: https://patch.msgid.link/20250109122216.3667847-4-cezary.rojewski@intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound/soc/intel/avs/apl.c')
| -rw-r--r-- | sound/soc/intel/avs/apl.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/soc/intel/avs/apl.c b/sound/soc/intel/avs/apl.c index 27516ef57185..d443fe8d51ae 100644 --- a/sound/soc/intel/avs/apl.c +++ b/sound/soc/intel/avs/apl.c @@ -125,7 +125,7 @@ int avs_apl_coredump(struct avs_dev *adev, union avs_notify_msg *msg) struct avs_apl_log_buffer_layout layout; void __iomem *addr, *buf; size_t dump_size; - u16 offset = 0; + u32 offset = 0; u8 *dump, *pos; dump_size = AVS_FW_REGS_SIZE + msg->ext.coredump.stack_dump_size; |