diff options
| author | Wei Wang <wei.w.wang@intel.com> | 2023-02-07 20:37:12 +0800 |
|---|---|---|
| committer | Sean Christopherson <seanjc@google.com> | 2023-06-13 14:18:09 -0700 |
| commit | 5ea5ca3c2b4bf4090232e18cfc515dcb52f914a6 (patch) | |
| tree | ceaa5ba4da71e1213afe13f44de19d8db1337137 /virt/kvm/eventfd.c | |
| parent | 5f643e460ab1298a32b7d0db104bfcab9d6165c0 (diff) | |
KVM: destruct kvm_io_device while unregistering it from kvm_io_bus
Current usage of kvm_io_device requires users to destruct it with an extra
call of kvm_iodevice_destructor after the device gets unregistered from
kvm_io_bus. This is not necessary and can cause errors if a user forgot
to make the extra call.
Simplify the usage by combining kvm_iodevice_destructor into
kvm_io_bus_unregister_dev. This reduces LOCs a bit for users and can
avoid the leakage of destructing the device explicitly.
Signed-off-by: Wei Wang <wei.w.wang@intel.com>
Reviewed-by: Sean Christopherson <seanjc@google.com>
Link: https://lore.kernel.org/r/20230207123713.3905-2-wei.w.wang@intel.com
Signed-off-by: Sean Christopherson <seanjc@google.com>
Diffstat (limited to 'virt/kvm/eventfd.c')
| -rw-r--r-- | virt/kvm/eventfd.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/virt/kvm/eventfd.c b/virt/kvm/eventfd.c index 7c42441425cf..4d47fffe03d9 100644 --- a/virt/kvm/eventfd.c +++ b/virt/kvm/eventfd.c @@ -931,7 +931,6 @@ kvm_deassign_ioeventfd_idx(struct kvm *kvm, enum kvm_bus bus_idx, bus = kvm_get_bus(kvm, bus_idx); if (bus) bus->ioeventfd_count--; - ioeventfd_release(p); ret = 0; break; } |