diff options
| author | Gabriel Krisman Bertazi <krisman@suse.de> | 2024-12-16 15:46:10 -0500 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2024-12-27 10:07:20 -0700 |
| commit | 1210872918ef9feff60c9f5a4d3246372b732eae (patch) | |
| tree | 203a75b50205c7ed2734d6417fe7a95c8bc265f6 | |
| parent | b2846567060638a85724579781fc4a3ca6f137e4 (diff) | |
io_uring/poll: Allocate apoll with generic alloc_cache helper
This abstracts away the cache details to simplify the code.
Signed-off-by: Gabriel Krisman Bertazi <krisman@suse.de>
Link: https://lore.kernel.org/r/20241216204615.759089-5-krisman@suse.de
Signed-off-by: Jens Axboe <axboe@kernel.dk>
| -rw-r--r-- | io_uring/poll.c | 13 |
1 files changed, 5 insertions, 8 deletions
diff --git a/io_uring/poll.c b/io_uring/poll.c index bced9edd5233..cc01c40b43d3 100644 --- a/io_uring/poll.c +++ b/io_uring/poll.c @@ -648,15 +648,12 @@ static struct async_poll *io_req_alloc_apoll(struct io_kiocb *req, if (req->flags & REQ_F_POLLED) { apoll = req->apoll; kfree(apoll->double_poll); - } else if (!(issue_flags & IO_URING_F_UNLOCKED)) { - apoll = io_alloc_cache_get(&ctx->apoll_cache); - if (!apoll) - goto alloc_apoll; - apoll->poll.retries = APOLL_MAX_RETRY; } else { -alloc_apoll: - apoll = kmalloc(sizeof(*apoll), GFP_ATOMIC); - if (unlikely(!apoll)) + if (!(issue_flags & IO_URING_F_UNLOCKED)) + apoll = io_cache_alloc(&ctx->apoll_cache, GFP_ATOMIC, NULL); + else + apoll = kmalloc(sizeof(*apoll), GFP_ATOMIC); + if (!apoll) return NULL; apoll->poll.retries = APOLL_MAX_RETRY; } |