summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorIlpo Järvinen <ilpo.jarvinen@linux.intel.com>2025-08-29 16:10:54 +0300
committerBjorn Helgaas <bhelgaas@google.com>2025-09-16 11:18:59 -0500
commit1ce76bc0497b9289d6f6195258d8bdc1c42eb91a (patch)
treee980745d5d893969ce93c280a66e7ae8b86947f5
parente240edffd04fe179536f7b5c22daae1e3b509b46 (diff)
PCI: Refactor find_bus_resource_of_type() logic checks
Reorder the logic checks in find_bus_resource_of_type() to simplify them. Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> Link: https://patch.msgid.link/20250829131113.36754-6-ilpo.jarvinen@linux.intel.com
-rw-r--r--drivers/pci/setup-bus.c10
1 files changed, 7 insertions, 3 deletions
diff --git a/drivers/pci/setup-bus.c b/drivers/pci/setup-bus.c
index 4097d8703b8f..c5fc4e2825be 100644
--- a/drivers/pci/setup-bus.c
+++ b/drivers/pci/setup-bus.c
@@ -158,11 +158,15 @@ static struct resource *find_bus_resource_of_type(struct pci_bus *bus,
struct resource *r, *r_assigned = NULL;
pci_bus_for_each_resource(bus, r) {
- if (r == &ioport_resource || r == &iomem_resource)
+ if (!r || r == &ioport_resource || r == &iomem_resource)
continue;
- if (r && (r->flags & type_mask) == type && !r->parent)
+
+ if ((r->flags & type_mask) != type)
+ continue;
+
+ if (!r->parent)
return r;
- if (r && (r->flags & type_mask) == type && !r_assigned)
+ if (!r_assigned)
r_assigned = r;
}
return r_assigned;