diff options
| author | Haotian Zhang <vulab@iscas.ac.cn> | 2025-11-18 20:14:27 +0800 |
|---|---|---|
| committer | Lee Jones <lee@kernel.org> | 2025-11-20 14:24:03 +0000 |
| commit | 384bd58bf7095e4c4c8fcdbcede316ef342c630c (patch) | |
| tree | 30d843677c5a2463a9a838a2c7952439a9b23b04 | |
| parent | b4b1bd1f330fdd13706382be6c90ce9f58cee3f5 (diff) | |
mfd: mt6358-irq: Fix missing irq_domain_remove() in error path
If devm_request_threaded_irq() fails after irq_domain_add_linear()
succeeds in mt6358_irq_init(), the function returns without removing
the created IRQ domain, leading to a resource leak.
Call irq_domain_remove() in the error path after a successful
irq_domain_add_linear() to properly release the IRQ domain.
Fixes: 2b91c28f2abd ("mfd: Add support for the MediaTek MT6358 PMIC")
Signed-off-by: Haotian Zhang <vulab@iscas.ac.cn>
Link: https://patch.msgid.link/20251118121427.583-1-vulab@iscas.ac.cn
Signed-off-by: Lee Jones <lee@kernel.org>
| -rw-r--r-- | drivers/mfd/mt6358-irq.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/mfd/mt6358-irq.c b/drivers/mfd/mt6358-irq.c index f467b00d2366..74cf20843044 100644 --- a/drivers/mfd/mt6358-irq.c +++ b/drivers/mfd/mt6358-irq.c @@ -285,6 +285,7 @@ int mt6358_irq_init(struct mt6397_chip *chip) if (ret) { dev_err(chip->dev, "Failed to register IRQ=%d, ret=%d\n", chip->irq, ret); + irq_domain_remove(chip->irq_domain); return ret; } |