diff options
| author | Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com> | 2025-10-10 13:44:46 -0700 |
|---|---|---|
| committer | Guenter Roeck <linux@roeck-us.net> | 2025-10-19 18:56:14 -0700 |
| commit | 72ac14851012d45dcbb9d3533e372e33001b873e (patch) | |
| tree | dcbe75fd2589a7d5029c5284f40c84ea9487b2da | |
| parent | ab0fd09d25e1d706e1ffc240f5cf66dcc89eeb49 (diff) | |
hwmon: (gpd-fan) Fix error handling in gpd_fan_probe()
devm_request_region() returns a NULL pointer on error, not an ERR_PTR().
Handle it accordingly.
Also fix error return from the call to devm_hwmon_device_register_with_info().
Fixes: 0ab88e239439 ("hwmon: add GPD devices sensor driver")
Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Reviewed-by: Cryolitia PukNgae <cryolitia@uniontech.com>
Link: https://lore.kernel.org/r/20251010204447.94343-1-harshit.m.mogalapalli@oracle.com
[groeck: Updated subject to improve readability]
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
| -rw-r--r-- | drivers/hwmon/gpd-fan.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/hwmon/gpd-fan.c b/drivers/hwmon/gpd-fan.c index eebe39ef9677..321794807e8d 100644 --- a/drivers/hwmon/gpd-fan.c +++ b/drivers/hwmon/gpd-fan.c @@ -621,8 +621,8 @@ static int gpd_fan_probe(struct platform_device *pdev) region = devm_request_region(dev, res->start, resource_size(res), DRIVER_NAME); - if (IS_ERR(region)) - return dev_err_probe(dev, PTR_ERR(region), + if (!region) + return dev_err_probe(dev, -EBUSY, "Failed to request region\n"); hwdev = devm_hwmon_device_register_with_info(dev, @@ -631,7 +631,7 @@ static int gpd_fan_probe(struct platform_device *pdev) &gpd_fan_chip_info, NULL); if (IS_ERR(hwdev)) - return dev_err_probe(dev, PTR_ERR(region), + return dev_err_probe(dev, PTR_ERR(hwdev), "Failed to register hwmon device\n"); return 0; |