diff options
| author | Bartosz Golaszewski <bartosz.golaszewski@linaro.org> | 2025-07-19 17:58:25 +0200 |
|---|---|---|
| committer | Arnd Bergmann <arnd@arndb.de> | 2025-07-21 18:04:15 +0200 |
| commit | 83d92eae8d44e320a414b76fcba8186fa739f3e8 (patch) | |
| tree | 5a7048673ee55bd4f833ecec05d2fdd8bb41eab4 | |
| parent | aee4eeec7e5e598f0b7da65405d43f9941f965a5 (diff) | |
pinctrl: rp1: use new GPIO line value setter callbacks
struct gpio_chip now has callbacks for setting line values that return
an integer, allowing to indicate failures. Convert the driver to using
them.
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Reviewed-by: Andrea della Porta <andrea.porta@suse.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
| -rw-r--r-- | drivers/pinctrl/pinctrl-rp1.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/drivers/pinctrl/pinctrl-rp1.c b/drivers/pinctrl/pinctrl-rp1.c index d300f28c52cd..6080b57a5d87 100644 --- a/drivers/pinctrl/pinctrl-rp1.c +++ b/drivers/pinctrl/pinctrl-rp1.c @@ -779,12 +779,14 @@ static int rp1_gpio_get(struct gpio_chip *chip, unsigned int offset) return ret; } -static void rp1_gpio_set(struct gpio_chip *chip, unsigned int offset, int value) +static int rp1_gpio_set(struct gpio_chip *chip, unsigned int offset, int value) { struct rp1_pin_info *pin = rp1_get_pin(chip, offset); if (pin) rp1_set_value(pin, value); + + return 0; } static int rp1_gpio_get_direction(struct gpio_chip *chip, unsigned int offset) @@ -849,7 +851,7 @@ static const struct gpio_chip rp1_gpio_chip = { .direction_output = rp1_gpio_direction_output, .get_direction = rp1_gpio_get_direction, .get = rp1_gpio_get, - .set = rp1_gpio_set, + .set_rv = rp1_gpio_set, .base = -1, .set_config = rp1_gpio_set_config, .ngpio = RP1_NUM_GPIOS, |