diff options
| author | Dan Carpenter <dan.carpenter@linaro.org> | 2025-07-16 14:43:45 -0500 |
|---|---|---|
| committer | Thomas Gleixner <tglx@linutronix.de> | 2025-07-18 14:54:45 +0200 |
| commit | aabf4ff06b9789f3cd167bf9e2eb25f1fdb5541a (patch) | |
| tree | 7207678afd4e468e036afe87d14c9076e09c4221 | |
| parent | 94b59d5f567a148a3eb25265a4e60f8605ff8423 (diff) | |
irqchip/ls-scfg-msi: Fix NULL dereference in error handling
The call to irq_domain_remove(msi_data->parent); was accidentally left
behind during a code refactor. It's not necessary to free
"msi_data->parent" because it is NULL and, in fact, trying to free it
will lead to a NULL pointer dereference. Delete the unnecessary code.
Fixes: 94b59d5f567a ("irqchip/ls-scfg-msi: Switch to use msi_create_parent_irq_domain()")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Nam Cao <namcao@linutronix.de>
Link: https://lore.kernel.org/all/15059507-6422-4333-94ca-e8e8840bd289@sabinyo.mountain
| -rw-r--r-- | drivers/irqchip/irq-ls-scfg-msi.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/irqchip/irq-ls-scfg-msi.c b/drivers/irqchip/irq-ls-scfg-msi.c index 7eca751d6548..4910f364e568 100644 --- a/drivers/irqchip/irq-ls-scfg-msi.c +++ b/drivers/irqchip/irq-ls-scfg-msi.c @@ -226,7 +226,6 @@ static int ls_scfg_msi_domains_init(struct ls_scfg_msi *msi_data) msi_data->parent = msi_create_parent_irq_domain(&info, &ls_scfg_msi_parent_ops); if (!msi_data->parent) { dev_err(&msi_data->pdev->dev, "failed to create MSI domain\n"); - irq_domain_remove(msi_data->parent); return -ENOMEM; } |