summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJason Gunthorpe <jgg@nvidia.com>2025-11-07 13:41:30 -0400
committerAlex Williamson <alex@shazbot.org>2025-11-12 15:05:02 -0700
commitf97859503859fd217d27fc4496f294955e197eaf (patch)
treed26238af50f6c48e61ee30d178bea7d2952cbf99
parente664067b603570164794facf06686434a12cb74d (diff)
vfio: Require drivers to implement get_region_info
Remove the fallback through the ioctl callback, no drivers use this now. Reviewed-by: Kevin Tian <kevin.tian@intel.com> Reviewed-by: Pranjal Shrivastava <praan@google.com> Reviewed-by: Mostafa Saleh <smostafa@google.com> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com> Link: https://lore.kernel.org/r/14-v2-2a9e24d62f1b+e10a-vfio_get_region_info_op_jgg@nvidia.com Signed-off-by: Alex Williamson <alex@shazbot.org>
-rw-r--r--drivers/vfio/vfio_main.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/vfio/vfio_main.c b/drivers/vfio/vfio_main.c
index a390163ce706..f056e82ba350 100644
--- a/drivers/vfio/vfio_main.c
+++ b/drivers/vfio/vfio_main.c
@@ -1297,13 +1297,13 @@ static long vfio_device_fops_unl_ioctl(struct file *filep,
break;
case VFIO_DEVICE_GET_REGION_INFO:
- if (!device->ops->get_region_info)
- goto ioctl_fallback;
- ret = device->ops->get_region_info(device, uptr);
+ if (unlikely(!device->ops->get_region_info))
+ ret = -EINVAL;
+ else
+ ret = device->ops->get_region_info(device, uptr);
break;
default:
-ioctl_fallback:
if (unlikely(!device->ops->ioctl))
ret = -EINVAL;
else