diff options
| author | Pablo Neira Ayuso <pablo@netfilter.org> | 2025-08-13 02:38:50 +0200 |
|---|---|---|
| committer | Florian Westphal <fw@strlen.de> | 2025-08-13 08:34:55 +0200 |
| commit | cf5fb87fcdaaaafec55dcc0dc5a9e15ead343973 (patch) | |
| tree | 6fad549773e16812f16f076f6626585cf0039e04 /lib/mpi/mpi-add.c | |
| parent | c0a23bbc98e93704a1f4fb5e7e7bb2d7c0fb6eb3 (diff) | |
netfilter: nf_tables: reject duplicate device on updates
A chain/flowtable update with duplicated devices in the same batch is
possible. Unfortunately, netdev event path only removes the first
device that is found, leaving unregistered the hook of the duplicated
device.
Check if a duplicated device exists in the transaction batch, bail out
with EEXIST in such case.
WARNING is hit when unregistering the hook:
[49042.221275] WARNING: CPU: 4 PID: 8425 at net/netfilter/core.c:340 nf_hook_entry_head+0xaa/0x150
[49042.221375] CPU: 4 UID: 0 PID: 8425 Comm: nft Tainted: G S 6.16.0+ #170 PREEMPT(full)
[...]
[49042.221382] RIP: 0010:nf_hook_entry_head+0xaa/0x150
Fixes: 78d9f48f7f44 ("netfilter: nf_tables: add devices to existing flowtable")
Fixes: b9703ed44ffb ("netfilter: nf_tables: support for adding new devices to an existing netdev chain")
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Florian Westphal <fw@strlen.de>
Diffstat (limited to 'lib/mpi/mpi-add.c')
0 files changed, 0 insertions, 0 deletions