diff options
author | Michal Luczaj <mhal@rbox.co> | 2025-06-09 19:08:03 +0200 |
---|---|---|
committer | Jakub Kicinski <kuba@kernel.org> | 2025-06-10 15:31:28 -0700 |
commit | 2660a544fdc0940bba15f70508a46cf9a6491230 (patch) | |
tree | 5bf9d18c3c58a5af969dd71fd5dd999ed50e6f51 /tools/perf/scripts/python/export-to-postgresql.py | |
parent | dc9c67820f81ee0d34f9095195228fcb828315ff (diff) |
net: Fix TOCTOU issue in sk_is_readable()
sk->sk_prot->sock_is_readable is a valid function pointer when sk resides
in a sockmap. After the last sk_psock_put() (which usually happens when
socket is removed from sockmap), sk->sk_prot gets restored and
sk->sk_prot->sock_is_readable becomes NULL.
This makes sk_is_readable() racy, if the value of sk->sk_prot is reloaded
after the initial check. Which in turn may lead to a null pointer
dereference.
Ensure the function pointer does not turn NULL after the check.
Fixes: 8934ce2fd081 ("bpf: sockmap redirect ingress support")
Suggested-by: Jakub Sitnicki <jakub@cloudflare.com>
Signed-off-by: Michal Luczaj <mhal@rbox.co>
Reviewed-by: Willem de Bruijn <willemb@google.com>
Link: https://patch.msgid.link/20250609-skisreadable-toctou-v1-1-d0dfb2d62c37@rbox.co
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'tools/perf/scripts/python/export-to-postgresql.py')
0 files changed, 0 insertions, 0 deletions